[ 
https://issues.apache.org/jira/browse/HBASE-23825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17034960#comment-17034960
 ] 

Abhishek Singh Chouhan commented on HBASE-23825:
------------------------------------------------

I've pushed to branch-1, 1.4, 1.3. Thanks for the reviews [~apurtell] 
[~anoop.hbase] [~sakthi]

> Increment proto conversion is broken
> ------------------------------------
>
>                 Key: HBASE-23825
>                 URL: https://issues.apache.org/jira/browse/HBASE-23825
>             Project: HBase
>          Issue Type: Bug
>          Components: Increment
>    Affects Versions: 1.4.0, 1.2.6, 1.3.2, 1.4.1, 1.5.0, 1.1.11, 1.3.3, 1.4.2, 
> 1.4.3, 1.4.4, 1.4.5, 1.3.2.1, 1.4.6, 1.4.8, 1.4.7, 1.4.9, 1.4.10, 1.3.4, 
> 1.3.5, 1.3.6, 1.4.11, 1.4.12
>            Reporter: Abhishek Singh Chouhan
>            Assignee: Abhishek Singh Chouhan
>            Priority: Blocker
>             Fix For: 1.6.0, 1.3.7, 1.4.13
>
>
> While converting the request back to Increment using ProtobufUtil.toIncrement 
> we incorrectly use the optimization to avoid copying the byte 
> array(HBaseZeroCopyByteString#zeroCopyGetBytes) on a BoundedByteString. The 
> optimization was only meant for LiteralByteString where it is safe to use the 
> backing byte array, however it ends up being used to BoundedByteString which 
> is a subclass of LiteralByteString. This essentially breaks increments since 
> we end up creating wrong cells on the server side. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to