ndimiduk commented on a change in pull request #754: HBASE-22978 : Online slow response log URL: https://github.com/apache/hbase/pull/754#discussion_r378447074
########## File path: hbase-thrift/src/main/java/org/apache/hadoop/hbase/thrift2/client/ThriftAdmin.java ########## @@ -1157,6 +1158,18 @@ public boolean isSnapshotCleanupEnabled() { throw new NotImplementedException("isSnapshotCleanupEnabled not supported in ThriftAdmin"); } + @Override + public List<SlowLogPayload> getSlowLogResponses(final List<ServerName> serverNames) + throws IOException { + throw new NotImplementedException("getSlowLogResponses not supported in ThriftAdmin"); + } + + @Override + public List<Boolean> clearSlowLogResponses(final List<ServerName> serverNames) + throws IOException { + throw new NotImplementedException("clearSlowLogsResponses not supported in ThriftAdmin"); Review comment: Hey @saintstack -- we are not maintaining parity with the thrift API, boss? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services