[ 
https://issues.apache.org/jira/browse/HBASE-5792?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254827#comment-13254827
 ] 

stack commented on HBASE-5792:
------------------------------

This is great Matteo.  We need this.  Yeah, agree, this tool will have most 
value if it puts nothing but a lone region (and WAL).

Few minors below:

Missing annotatations on audience.

Do you need these?  IIRC, the default exists w/ need of definition:

{code}
+  public HLogPerformanceEvaluation() {
+  }
{code}

You do it in another place at least too.

No harm adding a bit of class doc on HLogPutBenchmark

You don't want to use a command parser?


                
> HLog Performance Evaluation Tool
> --------------------------------
>
>                 Key: HBASE-5792
>                 URL: https://issues.apache.org/jira/browse/HBASE-5792
>             Project: HBase
>          Issue Type: Test
>          Components: wal
>            Reporter: Matteo Bertozzi
>            Assignee: Matteo Bertozzi
>            Priority: Minor
>              Labels: performance, wal
>         Attachments: HBASE-5792-v0.patch, HBASE-5792-v1.patch
>
>
> Related to HDFS-3280 and the HBase WAL slowdown on 0.23+
> It would be nice to have a simple tool like HFilePerformanceEvaluation, ...
> to be able to check easily the HLog performance.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to