ndimiduk commented on a change in pull request #1195: HBASE-23876 [WIP] Add JDK11 compilation and unit test support to nightly job URL: https://github.com/apache/hbase/pull/1195#discussion_r384848332
########## File path: dev-support/Jenkinsfile_GitHub ########## @@ -144,8 +143,9 @@ pipeline { YETUS_ARGS+=("--docker") YETUS_ARGS+=("--dockerfile=${DOCKERFILE}") YETUS_ARGS+=("--mvn-custom-repos") - YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8-openjdk-amd64") - YETUS_ARGS+=("--findbugs-home=/usr") + YETUS_ARGS+=("--java-home=/usr/lib/jvm/java-8") + YETUS_ARGS+=("--multijdkdirs=/usr/lib/jvm/java-8,/usr/lib/jvm/java-11") + YETUS_ARGS+=("--multijdktests=compile,unit") Review comment: I'm not sure what to tell you. This looks like explicit support to me, at least for running the unit tests with all supplied JDKs. https://github.com/apache/yetus/blob/138de2232a351e9d9f4c3d751e7d25e52804dfe0/precommit/src/main/shell/test-patch.sh#L2103-L2105 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services