wchevreuil commented on a change in pull request #1217: HBASE-23891: Add an option to Actions to filter out meta RS URL: https://github.com/apache/hbase/pull/1217#discussion_r385656098
########## File path: hbase-it/src/test/java/org/apache/hadoop/hbase/chaos/factories/ServerAndDependenciesKillingMonkeyFactory.java ########## @@ -83,5 +84,8 @@ private void loadProperties() { rollingBatchSuspendtRSRatio = Float.parseFloat(this.properties.getProperty( MonkeyConstants.ROLLING_BATCH_SUSPEND_RS_RATIO, MonkeyConstants.DEFAULT_ROLLING_BATCH_SUSPEND_RS_RATIO + "")); + killMetaRs = Boolean.parseBoolean(this.properties.getProperty( + MonkeyConstants.KILL_META_RS, + MonkeyConstants.DEFAULT_KILL_META_RS + "")); Review comment: Similar suggestion as done for the Actions. Can we move this to a common method in the parent class to avoid code repetition? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services