HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace
usages of HColumnDescriptor(byte [] familyName)…
URL: https://github.com/apache/hbase/pull/1222#discussion_r385982897
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/security/visibility/VisibilityController.java
##########
@@ -210,18 +211,21 @@ public void stop(CoprocessorEnvironment env) throws
IOException {
public void postStartMaster(ObserverContext<MasterCoprocessorEnvironment>
ctx) throws IOException {
// Need to create the new system table for labels here
if (!MetaTableAccessor.tableExists(ctx.getEnvironment().getConnection(),
LABELS_TABLE_NAME)) {
- HTableDescriptor labelsTable = new HTableDescriptor(LABELS_TABLE_NAME);
- HColumnDescriptor labelsColumn = new
HColumnDescriptor(LABELS_TABLE_FAMILY);
- labelsColumn.setBloomFilterType(BloomType.NONE);
- labelsColumn.setBlockCacheEnabled(false); // We will cache all the
labels. No need of normal
- // table block cache.
- labelsTable.addFamily(labelsColumn);
+ TableDescriptorBuilder.ModifyableTableDescriptor tableDescriptor =
+ new
TableDescriptorBuilder.ModifyableTableDescriptor(LABELS_TABLE_NAME);
+ ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor
familyDescriptor =
+ new
ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(LABELS_TABLE_FAMILY);
+ familyDescriptor.setBloomFilterType(BloomType.NONE);
+ familyDescriptor.setBlockCacheEnabled(false);
+ // We will cache all the labels. No need of normal
Review comment:
The comment should be above the line with setting the cache.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
