HorizonNet commented on a change in pull request #1222: HBASE-23868 : Replace usages of HColumnDescriptor(byte [] familyName)… URL: https://github.com/apache/hbase/pull/1222#discussion_r386274937
########## File path: hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java ########## @@ -72,14 +70,17 @@ public void testDuplicateVersions() throws IOException { byte[] familyBytes = Bytes.toBytes("Family"); TableName table = TableName.valueOf(name.getMethodName()); - HColumnDescriptor hcd = - new HColumnDescriptor(familyBytes).setMaxVersions(1000); - hcd.setMaxVersions(3); - HTableDescriptor htd = new HTableDescriptor(table); - htd.addFamily(hcd); + ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor familyDescriptor = + new ColumnFamilyDescriptorBuilder.ModifyableColumnFamilyDescriptor(familyBytes) + .setMaxVersions(1000); + familyDescriptor.setMaxVersions(3); Review comment: Use the builder. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services