nyl3532016 commented on a change in pull request #1243: HBASE-23944 The method
setClusterLoad of SimpleLoadBalancer is incorr…
URL: https://github.com/apache/hbase/pull/1243#discussion_r388762315
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/balancer/BalancerTestBase.java
##########
@@ -402,13 +402,13 @@ protected void updateLoad(final Map<ServerName,
ServerAndLoad> map,
return servers;
}
- protected HashMap<TableName, TreeMap<ServerName, List<RegionInfo>>>
mockClusterServersWithTables(Map<ServerName, List<RegionInfo>> clusterServers) {
- HashMap<TableName, TreeMap<ServerName, List<RegionInfo>>> result = new
HashMap<>();
+ protected Map<TableName, Map<ServerName, List<RegionInfo>>>
mockClusterServersWithTables(Map<ServerName, List<RegionInfo>> clusterServers) {
Review comment:
use the return value of method mockClusterServersWithTables as clusterLoad
the extend feature of treeMap is no use , Map is enough
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
