jojochuang commented on a change in pull request #15: HBASE-19256.
[hbase-thirdparty] shade jetty.
URL: https://github.com/apache/hbase-thirdparty/pull/15#discussion_r389723993
##########
File path: hbase-shaded-miscellaneous/pom.xml
##########
@@ -89,6 +89,38 @@
<pattern>org.apache.commons</pattern>
<shadedPattern>${rename.offset}.org.apache.commons</shadedPattern>
</relocation>
+ <relocation>
+ <pattern>org.eclipse.jetty</pattern>
+
<shadedPattern>${rename.offset}.org.eclipse.jetty</shadedPattern>
+ </relocation>
+ <relocation>
+ <pattern>javax</pattern>
Review comment:
thanks for the comment!
there are a bunch of javax.* classes in jetty and glassfish for the reason i
don't know. maybe they are shaded in jetty/glassfish but they don't relocate
them?
would you suggest i ignore these javax classes in hbase?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
