virajjasani commented on issue #1286: HBASE-23977 : Resolve flakes present in 
TestSlowLogRecorder
URL: https://github.com/apache/hbase/pull/1286#issuecomment-598796148
 
 
   > There's a utility method `waitUntil` that lets you wait for a condition to 
occur, or timeout. Check it's return value for the timeout case.
   
   Public methods related to `waitUntil` also seem to be waiting till specific 
duration.
   e.g
   ```
     public void waitUntilNoRegionsInTransition() throws IOException {
       waitUntilNoRegionsInTransition(15 * 60000);
     }
   ```
   
   May be better to use `waitFor` directly?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to