saintstack commented on a change in pull request #1280: HBASE-23799 Make our core coprocessors use shaded protobuf URL: https://github.com/apache/hbase/pull/1280#discussion_r394016223
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/client/coprocessor/BigDecimalColumnInterpreter.java ########## @@ -124,7 +125,7 @@ public void initialize(EmptyMsg msg) { private BigDecimalMsg getProtoForType(BigDecimal t) { BigDecimalMsg.Builder builder = BigDecimalMsg.newBuilder(); - return builder.setBigdecimalMsg(ByteStringer.wrap(Bytes.toBytes(t))).build(); + return builder.setBigdecimalMsg(UnsafeByteOperations.unsafeWrap(Bytes.toBytes(t))).build(); Review comment: Good ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services