[ https://issues.apache.org/jira/browse/HBASE-3614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13257787#comment-13257787 ]
stack commented on HBASE-3614: ------------------------------ Since you renamed RegionOperationMetrics, is this right now: {code} + private final OperationMetrics regionMetrics; {code} Should it be named metrics or operationMetrics? Whats 'unknown' in the following? + //null will be treated as unknown. We are updating metrics w/o attributing them to a cf? Fix misspell 'Inctement' in hbase-site change Patch is good to go after addressing above. Good stuff. > Expose per-region request rate metrics > -------------------------------------- > > Key: HBASE-3614 > URL: https://issues.apache.org/jira/browse/HBASE-3614 > Project: HBase > Issue Type: Improvement > Components: metrics, regionserver > Reporter: Gary Helmling > Assignee: Elliott Clark > Priority: Minor > Attachments: HBASE-3614-0.patch, HBASE-3614-1.patch, > HBASE-3614-2.patch, HBASE-3614-3.patch, HBASE-3614-4.patch, > HBASE-3614-5.patch, HBASE-3614-6.patch, HBASE-3614-7.patch, Screen Shot > 2012-04-17 at 2.41.27 PM.png > > > We currently export metrics on request rates for each region server, and this > can help with identifying uneven load at a high level. But once you see a > given server under high load, you're forced to extrapolate based on your > application patterns and the data it's serving what the likely culprit is. > This can and should be much easier if we just exported request rate metrics > per-region on each server. > Dynamically updating the metrics keys based on assigned regions may pose some > minor challenges, but this seems a very valuable diagnostic tool to have > available. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira