jojochuang commented on a change in pull request #12: HBASE-24124 hbase-filesystem to use guava from hbase-thirdparty URL: https://github.com/apache/hbase-filesystem/pull/12#discussion_r404471490
########## File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/HBaseObjectStoreSemantics.java ########## @@ -58,6 +57,7 @@ import org.apache.hadoop.hbase.oss.sync.TreeLockManager.Depth; import org.apache.hadoop.security.AccessControlException; import org.apache.hadoop.util.Progressable; +import org.apache.hbase.thirdparty.com.google.common.annotations.VisibleForTesting; Review comment: good point. in fact, the hbase1 profile has declares dependency on hbase-thirdparty, but not the hbase2 profile. I'll move the declaration out of the profile. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
