esteban commented on a change in pull request #1446: HBASE-23723 Ensure MOB
compaction works in optimized mode after snapshot clone
URL: https://github.com/apache/hbase/pull/1446#discussion_r405695486
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/mob/TestMobCompactionWithDefaults.java
##########
@@ -152,49 +167,102 @@ private void loadData(int num) {
public void tearDown() throws Exception {
admin.disableTable(tableDescriptor.getTableName());
admin.deleteTable(tableDescriptor.getTableName());
- HTU.shutdownMiniCluster();
}
-
+ @Test
public void baseTestMobFileCompaction() throws InterruptedException,
IOException {
+ LOG.info("MOB compaction " + description() + " started");
+ loadAndFlushThreeTimes(rows, table, famStr);
Review comment:
This is potentially a flakey test under load. Probably do an assert of the
number of MOB files/flushes before running the MOB compaction. We could retry
in a loop until we reach the required number of files by waiting until the
flushes are done?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
