[ https://issues.apache.org/jira/browse/HBASE-24161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17080108#comment-17080108 ]
Huaxiang Sun commented on HBASE-24161: -------------------------------------- Discussed with Stack, {code:java} Regarding with https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2.3/199/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.locking.TestEntityLocks.txt, The worker thread has returned from run(), but it may not be terminated by JVM/kernel yet, so isAlive() could still return true (for a very small gap). It makes sense to remove the assertion line (controlled by os, not the application logic) assertFalse(lock.getWorker().isAlive()); What we really want to test is if it is aborted, which is tested by the following line verify(abortable, times(1)).abort(any(), eq(null)); {code} > [flakey test] locking.TestEntityLocks.testEntityLockTimeout > ----------------------------------------------------------- > > Key: HBASE-24161 > URL: https://issues.apache.org/jira/browse/HBASE-24161 > Project: HBase > Issue Type: Test > Components: Client > Affects Versions: 3.0.0, 2.3.0, 2.4.0 > Reporter: Huaxiang Sun > Assignee: Hua Xiang > Priority: Minor > > From 2.3 flakey board, > [https://builds.apache.org/job/HBase-Flaky-Tests/job/branch-2.3/199/artifact/hbase-server/target/surefire-reports/org.apache.hadoop.hbase.client.locking.TestEntityLocks.txt] > > {code:java} > ------------------------------------------------------------------------------- > Test set: org.apache.hadoop.hbase.client.locking.TestEntityLocks > ------------------------------------------------------------------------------- > Tests run: 3, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.917 s <<< > FAILURE! - in org.apache.hadoop.hbase.client.locking.TestEntityLocks > org.apache.hadoop.hbase.client.locking.TestEntityLocks.testEntityLockTimeout > Time elapsed: 2.022 s <<< FAILURE! > java.lang.AssertionError > at > org.apache.hadoop.hbase.client.locking.TestEntityLocks.testEntityLockTimeout(TestEntityLocks.java:178) > Mapping to the code, it complains > assertFalse(lock.getWorker().isAlive()); > {code} -- This message was sent by Atlassian Jira (v8.3.4#803005)