saintstack commented on a change in pull request #1462: HBASE-24148: Upgrade Thrift to 0.13.0 URL: https://github.com/apache/hbase/pull/1462#discussion_r405957815
########## File path: pom.xml ########## @@ -1529,7 +1529,7 @@ <external.protobuf.version>2.5.0</external.protobuf.version> <protobuf.plugin.version>0.6.1</protobuf.plugin.version> <thrift.path>thrift</thrift.path> - <thrift.version>0.12.0</thrift.version> + <thrift.version>0.13.0</thrift.version> Review comment: Oh, do you have to regenerate the thrift files with this update? Will that happen as part of the build? (I forgot how this works) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services