binlijin commented on a change in pull request #1483: HBASE-24165 maxPoolSize
is logged incorrectly in ByteBufferPool
URL: https://github.com/apache/hbase/pull/1483#discussion_r406686329
##########
File path:
hbase-common/src/main/java/org/apache/hadoop/hbase/io/ByteBufferPool.java
##########
@@ -81,8 +81,7 @@ public ByteBufferPool(int bufferSize, int maxPoolSize,
boolean directByteBuffer)
this.directByteBuffer = directByteBuffer;
// TODO can add initialPoolSize config also and make those many BBs ready
for use.
LOG.info("Created with bufferSize={} and maxPoolSize={}",
- org.apache.hadoop.util.StringUtils.byteDesc(bufferSize),
- org.apache.hadoop.util.StringUtils.byteDesc(maxPoolSize));
+ org.apache.hadoop.util.StringUtils.byteDesc(bufferSize), maxPoolSize);
this.count = new AtomicInteger(0);
Review comment:
What about add (maxPoolSize* bufferSize) to the log also? So we can know the
actual maxPoolSize in byteDesc.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
