virajjasani commented on a change in pull request #1485: HBASE-23969 Meta
browser should show all `info` columns
URL: https://github.com/apache/hbase/pull/1485#discussion_r406750506
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/webapp/RegionReplicaInfo.java
##########
@@ -102,6 +117,27 @@ public ServerName getServerName() {
return serverName;
}
+ public String getTransitioningOnServerName() {
+ return transitioningOnServerName;
+ }
+
+ public String getMergeRegionName() {
+ return (mergeRegionInfo != null)
+ ? mergeRegionInfo.stream()
+ .map(RegionInfo::getRegionName)
+ .map(Bytes::toStringBinary)
+ .collect(Collectors.joining(", "))
+ : "";
Review comment:
nit: `? :` is good to use but here since we have some good computation, it
might be preferable to return empty string if regionInfo is null initially.
Better readability? WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
