virajjasani commented on a change in pull request #1494: HBASE-24174 Fix
findbugs warning in branch-1
URL: https://github.com/apache/hbase/pull/1494#discussion_r407343105
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/ipc/RpcServer.java
##########
@@ -2260,16 +2259,13 @@ public RpcServer(final Server server, final String
name,
}
@Override
- public void onConfigurationChange(Configuration newConf) {
+ public synchronized void onConfigurationChange(Configuration newConf) {
Review comment:
If we want to make this change, it should go to master, branch-2 first right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
