Apache9 commented on a change in pull request #1487: HBASE-23800 Add documentation about the CECPs changes URL: https://github.com/apache/hbase/pull/1487#discussion_r407953548
########## File path: src/main/asciidoc/_chapters/cp.adoc ########## @@ -193,6 +209,12 @@ link:https://issues.apache.org/jira/browse/HBASE-5448[HBASE-5448]). To upgrade y HBase cluster from 0.94 or earlier to 0.96 or later, you need to reimplement your coprocessor. +In HBase 2.0.0, we make use of a shaded version of protobuf 3.x, but still keep the +protobuf for coprocessor on 2.5.0. In 3.0.0, we removed all dependencies on non-shaded +protobuf so you need to reimplement your coprocessor to make use of the shaded protobuf +version provided in hbase-thirdparty. Please see the <<protobuf,protobuf>> section for Review comment: I think this is why we need a hbase-protocol modue in the past? The CPEP implementation could reference the protobuf defination. And in general, adding breaking changes to proto files is a no no, it will break wire compatible, so I think it is fine to reference them? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
