richardantal commented on a change in pull request #55: HBASE-24039
URL:
https://github.com/apache/hbase-operator-tools/pull/55#discussion_r408156087
##########
File path: hbase-hbck2/src/main/java/org/apache/hbase/HBCK2.java
##########
@@ -133,6 +143,19 @@ void checkHBCKSupport(ClusterConnection connection,
String cmd, String ... suppo
}
}
+ void checkFunctionSupported(ClusterConnection connection, String cmd) throws
IOException {
+ if (skipCheck) {
+ LOG.info("Skipped {} command version check; 'skip' set", cmd);
+ return;
+ }
+ List<Method> methods =
Arrays.asList(connection.getHbck().getClass().getDeclaredMethods());
Review comment:
I am not an expert in this topic but I think it does not makes sense to run
hbck on personal computer to repair a remote HBase. The user should run hbck on
the same computer where the problem is. (using ssh for example.) This way the
program would get the jar with the correct version.
Anyway we can continue work on a follow up solution where we get methods
from the Master itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
