saintstack commented on a change in pull request #1485: HBASE-23969 Meta 
browser should show all `info` columns
URL: https://github.com/apache/hbase/pull/1485#discussion_r409159744
 
 

 ##########
 File path: 
hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java
 ##########
 @@ -966,6 +965,33 @@ public static ServerName getServerName(final Result r, 
final int replicaId) {
     }
   }
 
+  /**
+   * Returns the {@link ServerName} from catalog table {@link Result} where 
the region is
+   * transitioning on. It should be the same as {@link 
MetaTableAccessor#getServerName(Result,int)}
+   * if the server is at OPEN state.
+   *
+   * @param r Result to pull the transitioning server name from
+   * @return A ServerName instance or {@link 
MetaTableAccessor#getServerName(Result,int)}
+   * if necessary fields not found or empty.
+   */
+  @Nullable
+  public static ServerName getTargetServerName(final Result r, final int 
replicaId) {
 
 Review comment:
   What is rationale for moving this method? How is it MetaTableAccessor 
material?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to