[ 
https://issues.apache.org/jira/browse/HBASE-23969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17084471#comment-17084471
 ] 

Mingliang Liu commented on HBASE-23969:
---------------------------------------

[~stack] Good questions on names in table.jsp. I see the existing items in 
table.jsp are using meaningful names instead of column names in {{hbase:meta}} 
table. Specially the current "ServerName" in table.jsp is composed of 
"info:server" + "info:startcode*" columns in hbase:meta table.
{quote}
Would suggest no interpretation of the base:meta table content.... 
{quote}
I'm not sure no interpretation makes perfect sense. We can make this new 
*Target ServerName*  use its name in hbase:meta "info:sn". Some concerns are:
# Should existing "ServerName" use *info:server,info:startcode*? Or we split it 
into two columns in table.jsp as they are in hbase:meta. Even with that, the 
column name for startcode could still be *info:startcode* or 
*info:serverstartcode_<replicaId>*
# As I mentioned to [~ndimiduk], the "info:merge*" columns could have more than 
two, and their names could be *mergeA*/*mergeB* or *merge0000*/*merge0001*. 
Showing this in table.jsp with a static format is not straightforward to me. If 
we show raw data in hbase:meta here, we may need all columns 
"mergeA/mergeB/merge0000/merge0001/..." (they are empty most times) in 
table.jsp. I was assuming the table.jsp viewer cares about the parent regions 
than the stored column name in hbase:meta, so I merged them together. 
SplitA/SplitB names and number of columns in hbase:meta are static so we did 
not merge them.
# There might be other hbase:meta columns eventually which have different name 
across HBase versions. I guess expressing those data without any interpretation 
is not ideal either.

So, for the sake of least "interpretation" of the hbase:meta table, my proposal 
is:
# Rename existing *ServerName* to *Server* in table.jsp, which shows the 
"info:server"+"info:startcode*" columns. Keep *Target Server* for column 
*info:sn* since this is clear and simple.
# Still show *info:merge** data together in table.jsp with newline-delimited 
list. Show *info:splitA* and *info:SplitB* together as well, so they follow the 
same pattern.
# Rename the *Merger ServerName* column in table.jsp *info:merge** which is 
regex of possible column names in hbase:meta
# Name the *SplitA/SplitB* column in table.jsp *info:split** which is regex of 
column names in hbase:meta
# Add [tooltip|https://en.wikipedia.org/wiki/Tooltip] for each column in table 
head, so it would show the detailed comment what this is about.

Thoughts? [~ndimiduk][~vjasani]



> Meta browser should show all `info` columns
> -------------------------------------------
>
>                 Key: HBASE-23969
>                 URL: https://issues.apache.org/jira/browse/HBASE-23969
>             Project: HBase
>          Issue Type: Improvement
>          Components: master, UI
>    Affects Versions: 3.0.0, 2.3.0
>            Reporter: Nick Dimiduk
>            Assignee: Mingliang Liu
>            Priority: Minor
>         Attachments: Screen Shot 2020-04-10 at 4.02.50 AM.png, Screen Shot 
> 2020-04-11 at 3.27.57 AM.png
>
>
> The Meta table browser lists region states. There are other {{info}} columns 
> in the table, which should be displayed. Looking through {{HConstants}}, it 
> seems we need to add the following:
>  * {{server}}
>  * {{sn}}
>  * {{splitA}}
>  * {{splitB}}
>  * {{merge}}
>  * {{mergeA}}
>  * {{mergeB}}
> Are there others?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to