virajjasani commented on issue #1511: HBASE-24139 : Balancer should avoid leaving idle region servers URL: https://github.com/apache/hbase/pull/1511#issuecomment-614655630 > As a part of moving the method for finding idle RS up to BaseLoadBalancer it is probably worth also having this short circuit decision present in that class's `needsBalance` method. > > reviews so far cover anything else I'd have concern with. Oh yes, keeping short circuit in `BaseLoadBalancer`'s `needsBalance()` definitely makes sense
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
