[
https://issues.apache.org/jira/browse/HBASE-24206?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17085898#comment-17085898
]
Michael Stack commented on HBASE-24206:
---------------------------------------
CODE-BUG to me says we have hit an area where we need coverage/code-to-deal
with the failure. It usually means a condition we've not seen before and that
we need a fix to cover the condition.
This patch would just log and move on. The Procedure will be in a messed-up
state if we do this?
> Unsupported rollback should not be logged as CODE-BUG
> ------------------------------------------------------
>
> Key: HBASE-24206
> URL: https://issues.apache.org/jira/browse/HBASE-24206
> Project: HBase
> Issue Type: Improvement
> Components: logging, proc-v2
> Reporter: Peter Somogyi
> Assignee: Peter Somogyi
> Priority: Minor
>
> When executing rollback from a state that does not support rollback
> functionality UnsupportedOperationException is thrown. The Procedure
> framework does not handle this case specially and logs an ERROR message
> because it is caught as a Throwable.
> This scenario should have a cleaner log message.
> {noformat}
> 2020-04-08 20:57:10,137 ERROR
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor: CODE-BUG: Uncaught
> runtime exception for pid=14791, state=FAILED:SERVER_CRASH_START,
> locked=true,
> exception=org.apache.hadoop.hbase.procedure2.ProcedureAbortedException via
> AssignProcedure:org.apache.hadoop.hbase.procedure2.ProcedureAbortedException:
> 6f48ff190e182c204056eb8b227ff6e8 owned by pid=9419, CANNOT run 'this'
> (pid=14797).; ServerCrashProcedure server=example.com,16020,1584086541944,
> splitWal=true, meta=false
> java.lang.UnsupportedOperationException: unhandled
> state=SERVER_CRASH_GET_REGIONS
> at
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.rollbackState(ServerCrashProcedure.java:265)
> at
> org.apache.hadoop.hbase.master.procedure.ServerCrashProcedure.rollbackState(ServerCrashProcedure.java:59)
> at
> org.apache.hadoop.hbase.procedure2.StateMachineProcedure.rollback(StateMachineProcedure.java:208)
> at
> org.apache.hadoop.hbase.procedure2.Procedure.doRollback(Procedure.java:982)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1663)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeRollback(ProcedureExecutor.java:1595)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.executeProcedure(ProcedureExecutor.java:1438)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor.access$1200(ProcedureExecutor.java:78)
> at
> org.apache.hadoop.hbase.procedure2.ProcedureExecutor$WorkerThread.run(ProcedureExecutor.java:2058)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
