ndimiduk opened a new pull request #1547: HBASE-23894 Support ErrorProne for both JDK8 and JDK11 URL: https://github.com/apache/hbase/pull/1547 ErrorProne uses an extension interface that's only available on javac from JDK9+. Thus, its configuration for JDK8 is quite different from later JVM versions. These configurations are mutually exclusive, I haven't seen any documentation for project that compile on both javac verions. Thus this implementation based on different maven profiles. The situation is further complicated by maven not allowing profile activation based on multiple conditions. In our case, we'd like to do profile select based on both the active JDK and the presense of some enablement flag, such as -DerrorProne. This seems to be impossible. Thus, the solution presented here is to define two profiles, neither active by default. When a user wishes to run Error Prone, they must activate the profile that is appropriate to their version of javac.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
