[ https://issues.apache.org/jira/browse/HBASE-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259155#comment-13259155 ]
Zhihong Yu commented on HBASE-5833: ----------------------------------- For the 0.92 patch, I ran TestMasterFailover 5 times and didn't see hanging. Good job. There're several places where line length exceeds 100 characters: {code} + * This will do the necessary cleanup a call to {@link #createHRegion(HRegionInfo, Path, Configuration, HTableDescriptor)} {code} For JVMClusterUtil.java, is the following change needed ? {code} - for (JVMClusterUtil.MasterThread t : masters) { + for (JVMClusterUtil.MasterThread t: masters) { {code} A new method, closeHRegion(), has been added to HRegion. In TestColumnPrefixFilter.java, etc. I see: {code} + } finally { + region.close(); + region.getLog().closeAndDelete(); {code} Can HRegion.closeHRegion() be used instead ? > 0.92 build has been failing pretty consistently on TestMasterFailover.... > ------------------------------------------------------------------------- > > Key: HBASE-5833 > URL: https://issues.apache.org/jira/browse/HBASE-5833 > Project: HBase > Issue Type: Bug > Reporter: stack > Assignee: stack > Fix For: 0.92.2 > > Attachments: 5833-trunk.txt, 5833-v2.092.txt, 5833.txt, > closehregions.txt > > > Trunk seems fine but 0.92 fails on this test pretty regularly. Running it > local it seems to hang for me. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira