virajjasani commented on a change in pull request #1541: HBASE-24206
Unsupported rollback should not be logged as CODE-BUG
URL: https://github.com/apache/hbase/pull/1541#discussion_r410689606
##########
File path:
hbase-procedure/src/main/java/org/apache/hadoop/hbase/procedure2/ProcedureExecutor.java
##########
@@ -1596,9 +1596,11 @@ private LockState
executeRollback(Procedure<TEnvironment> proc) {
} catch (InterruptedException e) {
handleInterruptedException(proc, e);
return LockState.LOCK_YIELD_WAIT;
+ } catch (UnsupportedOperationException e) {
+ LOG.debug("Rollback is not supported for {}", proc);
Review comment:
Or maybe we can check for `UnsupportedOperationException`'s cause to verify
this is rollback only and not something else? Anyways, I don't have any strong
case here, just trying to understand it better.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
