arshadmohammad commented on a change in pull request #1546: HBASE-24211: Create
table is slow in large cluster when AccessController is enabled.
URL: https://github.com/apache/hbase/pull/1546#discussion_r410716897
##########
File path:
hbase-zookeeper/src/main/java/org/apache/hadoop/hbase/zookeeper/ZKUtil.java
##########
@@ -741,6 +741,10 @@ public static int getNumberOfChildren(ZKWatcher zkw,
String znode)
if (nodes != null) {
List<NodeAndData> newNodes = new ArrayList<>();
for (String node : nodes) {
+ if (Thread.interrupted()) {
+ // Partial data should not be processed. Cancel processing by
sending empty list.
Review comment:
getChildDataAndWatchForNewChildren is called from many places, but it is
interrupted from ZKPermissionWatcher#nodeChildrenChanged() by calling
childrenChangedFuture.cancel. Here cancel/interrupt indicates that we have
more updated data, no need to proceed with the old data. Returning empty is for
graceful exit of the processing.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
