virajjasani commented on a change in pull request #1511:
URL: https://github.com/apache/hbase/pull/1511#discussion_r411561974
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/master/balancer/BaseLoadBalancer.java
##########
@@ -1223,6 +1227,20 @@ protected boolean areSomeRegionReplicasColocated(Cluster
c) {
return false;
}
+ protected final synchronized boolean idleRegionExist(Cluster c){
Review comment:
Hmm, as part of HBASE-12559, many methods that are overridden in
`StochasticLoadBalancer` are made `synchronized` due to findbugs warnings. I
was surprised to see all these methods non-synchronized in parent and
synchronized in child class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
