saintstack commented on a change in pull request #1548:
URL: https://github.com/apache/hbase/pull/1548#discussion_r411873306



##########
File path: dev-support/hbase-personality.sh
##########
@@ -146,7 +146,7 @@ function personality_modules
   fi
 
   if [[ -n "${HADOOP_PROFILE}" ]]; then
-    extra="${extra} -Dhadoop.profile=${HADOOP_PROFILE}"
+    extra="${extra} -Phadoop-${HADOOP_PROFILE}"

Review comment:
       Why this change? Makes it easier than what was there previous when you 
want to swap profiles?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to