[ https://issues.apache.org/jira/browse/HBASE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viraj Jasani resolved HBASE-23264. ---------------------------------- Fix Version/s: 2.2.5 1.7.0 2.3.0 3.0.0 Hadoop Flags: Reviewed Resolution: Fixed Pushed to master, branch-2, 2.3, 2.2 and branch-1.7. Thanks for the contribution [~filtertip]. > Resolve a TODO of BucketAllocator: "Why we add the extra 1024 bytes? Slop?" > --------------------------------------------------------------------------- > > Key: HBASE-23264 > URL: https://issues.apache.org/jira/browse/HBASE-23264 > Project: HBase > Issue Type: Improvement > Components: BucketCache > Reporter: Zheng Wang > Assignee: Zheng Wang > Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.5 > > > {code:java} > // TODO: Why we add the extra 1024 bytes? Slop? > private static final int DEFAULT_BUCKET_SIZES[] = { 4 * 1024 + 1024, 8 * 1024 > + 1024, > 16 * 1024 + 1024, 32 * 1024 + 1024, 40 * 1024 + 1024, 48 * 1024 + 1024, > 56 * 1024 + 1024, 64 * 1024 + 1024, 96 * 1024 + 1024, 128 * 1024 + 1024, > 192 * 1024 + 1024, 256 * 1024 + 1024, 384 * 1024 + 1024, > 512 * 1024 + 1024 };{code} > The real block size in hfile may a little larger than the size we configured > ,so we need add extra 1024 bytes for fit. -- This message was sent by Atlassian Jira (v8.3.4#803005)