[ https://issues.apache.org/jira/browse/HBASE-23264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17093389#comment-17093389 ]
Hudson commented on HBASE-23264: -------------------------------- Results for branch branch-1 [build #1290 on builds.a.o|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1290/]: (x) *{color:red}-1 overall{color}* ---- details (if available): (/) {color:green}+1 general checks{color} -- For more information [see general report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1290//General_Nightly_Build_Report/] (x) {color:red}-1 jdk7 checks{color} -- For more information [see jdk7 report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1290//JDK7_Nightly_Build_Report/] (/) {color:green}+1 jdk8 hadoop2 checks{color} -- For more information [see jdk8 (hadoop2) report|https://builds.apache.org/job/HBase%20Nightly/job/branch-1/1290//JDK8_Nightly_Build_Report_(Hadoop2)/] (x) {color:red}-1 source release artifact{color} -- See build output for details. > Resolve a TODO of BucketAllocator: "Why we add the extra 1024 bytes? Slop?" > --------------------------------------------------------------------------- > > Key: HBASE-23264 > URL: https://issues.apache.org/jira/browse/HBASE-23264 > Project: HBase > Issue Type: Improvement > Components: BucketCache > Reporter: Zheng Wang > Assignee: Zheng Wang > Priority: Minor > Fix For: 3.0.0, 2.3.0, 1.7.0, 2.2.5 > > > {code:java} > // TODO: Why we add the extra 1024 bytes? Slop? > private static final int DEFAULT_BUCKET_SIZES[] = { 4 * 1024 + 1024, 8 * 1024 > + 1024, > 16 * 1024 + 1024, 32 * 1024 + 1024, 40 * 1024 + 1024, 48 * 1024 + 1024, > 56 * 1024 + 1024, 64 * 1024 + 1024, 96 * 1024 + 1024, 128 * 1024 + 1024, > 192 * 1024 + 1024, 256 * 1024 + 1024, 384 * 1024 + 1024, > 512 * 1024 + 1024 };{code} > The real block size in hfile may a little larger than the size we configured > ,so we need add extra 1024 bytes for fit. -- This message was sent by Atlassian Jira (v8.3.4#803005)