[ 
https://issues.apache.org/jira/browse/HBASE-5830?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259855#comment-13259855
 ] 

Uma Maheswara Rao G commented on HBASE-5830:
--------------------------------------------

{quote} -1 tests included.  The patch doesn't appear to include any new or 
modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.
{quote}

No tests included , as this is the patch to use the SequenceFile#Writer API 
directly, instead of using reflections.

Thanks a lot, Stack for the review!
                
> Cleanup SequenceFileLogWriter to use syncFs api from SequenceFile#Writer 
> directly in trunk.
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-5830
>                 URL: https://issues.apache.org/jira/browse/HBASE-5830
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.96.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HBASE-5830.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to