ystaticy commented on a change in pull request #1588:
URL: https://github.com/apache/hbase/pull/1588#discussion_r417789507
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CompactSplit.java
##########
@@ -742,12 +744,27 @@ public void onConfigurationChange(Configuration newConf) {
}
}
- ThroughputController old = this.compactionThroughputController;
- if (old != null) {
- old.stop("configuration change");
+ String newCompactClass = newConf.get(
+ CompactionThroughputControllerFactory.HBASE_THROUGHPUT_CONTROLLER_KEY);
+ String oldCompactClass = conf.get(
Review comment:
> get oldCompactClass from compactionThroughputController? conf and
newConf should ref to the same object.
Thank you .I'll modify the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
