[
https://issues.apache.org/jira/browse/HBASE-5801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259912#comment-13259912
]
jirapos...@reviews.apache.org commented on HBASE-5801:
------------------------------------------------------
bq. On 2012-04-23 08:08:05, jmhsieh wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1239
bq. >
<https://reviews.apache.org/r/4833/diff/2/?file=103677#file103677line1239>
bq. >
bq. > Check return value and warn / throw exn if fails.
Will fix.
bq. On 2012-04-23 08:08:05, jmhsieh wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1591
bq. >
<https://reviews.apache.org/r/4833/diff/2/?file=103677#file103677line1591>
bq. >
bq. > Did you intend for this to always happen or only if the user had set
the fixTableDesc option?
This will always happen in the fixing mode evnet fixTableDesc is not set.
Otherwise, hbck can't move on if there are multiple table desc.
bq. On 2012-04-23 08:08:05, jmhsieh wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1592
bq. >
<https://reviews.apache.org/r/4833/diff/2/?file=103677#file103677line1592>
bq. >
bq. > This should probably at least WARN.
Changed to WARN.
bq. On 2012-04-23 08:08:05, jmhsieh wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 2476
bq. >
<https://reviews.apache.org/r/4833/diff/2/?file=103677#file103677line2476>
bq. >
bq. > typo: "Mutliple"
Fixed.
bq. On 2012-04-23 08:08:05, jmhsieh wrote:
bq. > src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java, line 923
bq. > <https://reviews.apache.org/r/4833/diff/2/?file=103679#file103679line923>
bq. >
bq. > nit: awkward comment.
Changed it a little bit.
bq. On 2012-04-23 08:08:05, jmhsieh wrote:
bq. > src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java, line 1238
bq. >
<https://reviews.apache.org/r/4833/diff/2/?file=103677#file103677line1238>
bq. >
bq. > Check return value and warn / throw exn if fails.
I think this one is fine if I fix the next one.
- Jimmy
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4833/#review7126
-----------------------------------------------------------
On 2012-04-20 22:45:47, Jimmy Xiang wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/4833/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-04-20 22:45:47)
bq.
bq.
bq. Review request for hbase and jmhsieh.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Added option to fix inconsistent table descriptors:
bq. 1. sideline the current .regioninfo file
bq. 2. create a new one with HTD from HBaseAdmin (meta, first entry)
bq. 3. offline the region and wait till it assigned again
bq.
bq.
bq. This addresses bug HBASE-5801.
bq. https://issues.apache.org/jira/browse/HBASE-5801
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java 50f9128
bq. src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java 06d2b73
bq. src/test/java/org/apache/hadoop/hbase/util/TestHBaseFsck.java 103d8bf
bq.
bq. Diff: https://reviews.apache.org/r/4833/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. TestHBaseFsck* are green. On live cluster, it does the fix as expected.
bq.
bq.
bq. Thanks,
bq.
bq. Jimmy
bq.
bq.
> [hbck] Hbck should handle case where some regions have different HTD settings
> in .regioninfo files (0.90 specific)
> -------------------------------------------------------------------------------------------------------------------
>
> Key: HBASE-5801
> URL: https://issues.apache.org/jira/browse/HBASE-5801
> Project: HBase
> Issue Type: Improvement
> Components: hbck
> Affects Versions: 0.90.7
> Reporter: Jonathan Hsieh
> Assignee: Jimmy Xiang
>
> Recently, we encountered a case where some regions in a table have different
> HTableDescriptor settings serialized into HDFS their HRegionInfo .regioninfo
> file. hbck expects all HTDs within a table to be the same and currently
> bails out in this situation.
> We need to either point out a proper set of actions for the user to execute
> or automatically convert the region to a common HTD (likely the most common
> on, or possibly the "first one".)
> Not sure if this requires reformatting data but may require closing and
> restarting a region.
> This issue is hbase 0.90.x specific -- 0.92+ keep all table info in a single
> .tableinfo file.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
