huaxiangsun commented on a change in pull request #1584: URL: https://github.com/apache/hbase/pull/1584#discussion_r419571294
########## File path: hbase-client/src/main/java/org/apache/hadoop/hbase/MetaTableAccessor.java ########## @@ -1846,6 +1846,16 @@ public static void deleteMergeQualifiers(Connection connection, final RegionInfo qualifiers.add(qualifier); delete.addColumns(getCatalogFamily(), qualifier, HConstants.LATEST_TIMESTAMP); } + + // There will be race condition that a GCMultipleMergedRegionsProcedure is scheduled while + // the previous GCMultipleMergedRegionsProcedure is still going on, in this case, the second + // GCMultipleMergedRegionsProcedure could delete the merged region by accident! + if (qualifiers.isEmpty()) { Review comment: Thanks @saintstack . I create HBASE-24256 to track GCMulitpleMergedRegionsProcedure issue, will drop the fix code in this patch and upload a new patch. In HBASE-24256, I will add an unitest to show the issue. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org