ndimiduk commented on pull request #1593: URL: https://github.com/apache/hbase/pull/1593#issuecomment-623577892
Seems we've lead @bharathv down a rabbit hole. These changes are part of a feature new for 2.3.0, so I prefer that they are settled before the release. I'm still in the process of setting up my infrastructure for running ITBLL tests in the peculiarities of my environment (see my recent patches around the chaos monkey tools). Thus there's still time. Please take the time to see this resolved before the first RC, whichever direction you choose to take it. Go ahead and mark appropriate JIRAs as blockers for 2.3.0. My one request is that we update the class names, class-level javadoc, and package level javadoc to more clearly describe what's going on here **and why**. It seems that what structures we have in place are not enough for multiple developers familiar with the codebase to understand the subtleties of this subsystem. No offense @Apache9, but more people than just you need to be able to provide meaningful code review on our RPC implementation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
