gjacoby126 commented on a change in pull request #1655:
URL: https://github.com/apache/hbase/pull/1655#discussion_r420460681
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/CustomizedScanInfoBuilder.java
##########
@@ -34,8 +36,18 @@
private KeepDeletedCells keepDeletedCells = null;
+ private Integer minVersions;
+
+ private final Scan scan;
+
public CustomizedScanInfoBuilder(ScanInfo scanInfo) {
this.scanInfo = scanInfo;
+ this.scan = new Scan();
+ }
+ public CustomizedScanInfoBuilder(ScanInfo scanInfo, Scan scan) throws
IOException {
Review comment:
Looks like the copy constructor for Scan has thrown IOException back
since 2009, but the current code does not actually contain anything that throws
it. Since I assume changing the signature is more trouble than it's worth, I
just had to rethrow from the CustomizedScanInfoBuilder constructor and
getScan() methods.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
