liuml07 commented on a change in pull request #1485:
URL: https://github.com/apache/hbase/pull/1485#discussion_r420569058
##########
File path: hbase-server/src/main/resources/hbase-webapps/master/table.jsp
##########
@@ -387,68 +388,93 @@ if (fqtn != null && master.isInitialized()) {
}
}
%>
-<table class="table table-striped">
- <tr>
- <th>RegionName</th>
- <th>Start Key</th>
- <th>End Key</th>
- <th>Replica ID</th>
- <th>RegionState</th>
- <th>ServerName</th>
- </tr>
-<%
- final boolean metaScanHasMore;
- byte[] lastRow = null;
- try (final MetaBrowser.Results results = metaBrowser.getResults()) {
- for (final RegionReplicaInfo regionReplicaInfo : results) {
- lastRow = Optional.ofNullable(regionReplicaInfo)
- .map(RegionReplicaInfo::getRow)
- .orElse(null);
- if (regionReplicaInfo == null) {
-%>
- <tr>
- <td colspan="6">Null result</td>
- </tr>
-<%
- continue;
- }
+<div style="overflow-x: auto">
+ <table class="table table-striped nowrap">
+ <tr>
+ <th title="Region name">RegionName</th>
+ <th title="The startKey of this region">Start Key</th>
+ <th title="The endKey of this region">End Key</th>
+ <th title="Region replica id">Replica ID</th>
+ <th title="State of the region while undergoing
transitions">RegionState</th>
+ <th title="Server hosting this region replica, stored in info:server
column">Server</th>
Review comment:
I like the idea. I have changed that. To make this table header fit in
one line, I have defined some column name variables, which can be reused.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
