saintstack commented on a change in pull request #1640:
URL: https://github.com/apache/hbase/pull/1640#discussion_r422369449
##########
File path: hbase-assembly/pom.xml
##########
@@ -318,5 +318,18 @@
<artifactId>jaxws-ri</artifactId>
<type>pom</type>
</dependency>
+ <!--
+ Include the log framework here.
+ For other sub modules, we only declare slf4j-api as a compile dependency,
+ so here we must pull in the real logging framework to actually log to
log4j.
+ -->
Review comment:
I'm asking about running an hbase instance from built checkout, not from
an assembly. Currently it works. It looks like it will no longer work if this
patch goes in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
