HorizonNet commented on a change in pull request #1734:
URL: https://github.com/apache/hbase/pull/1734#discussion_r426905116
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/master/normalizer/TestSimpleRegionNormalizerOnCluster.java
##########
@@ -179,6 +182,71 @@ void testRegionNormalizationSplitOnCluster(boolean
limitedByQuota) throws Except
admin.deleteTable(TABLENAME);
}
+ // This test is to make sure that normalizer is only going to merge adjacent
regions.
+ @Test
+ @SuppressWarnings("deprecation")
Review comment:
What deprecations are needed here?
##########
File path:
hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
##########
@@ -1519,6 +1519,17 @@ public Table createMultiRegionTable(TableName tableName,
byte[][] families) thro
return createTable(tableName, families, KEYS_FOR_HBA_CREATE_TABLE);
}
+ /**
+ * Create a table with multiple regions.
+ * @param tableName
Review comment:
Can you please add the missing Javadoc?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
