[GitHub] [hbase] wenbang commented on a change in pull request #1742: HBASE-24401 Cell size limit check on append should consider 0 or less…

[GitBox]

wenbang commented on a change in pull request #1742:
URL: https://github.com/apache/hbase/pull/1742#discussion_r427999411



##########
File path: 
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -8265,14 +8265,16 @@ private WALEdit reckonDeltas(Operation op, Mutation 
mutation, Durability effecti
           break;
         default: throw new UnsupportedOperationException(op.toString());
       }
-      int newCellSize = PrivateCellUtil.estimatedSerializedSizeOf(newCell);
-      if (newCellSize > this.maxCellSize) {
-        String msg = "Cell with size " + newCellSize + " exceeds limit of " + 
this.maxCellSize
-          + " bytes in region " + this;
-        if (LOG.isDebugEnabled()) {
-          LOG.debug(msg);
+      if (this.maxCellSize > 0) {
+        int newCellSize = PrivateCellUtil.estimatedSerializedSizeOf(newCell);
+        if (newCellSize > this.maxCellSize) {
+          String msg = "Cell with size " + newCellSize + " exceeds limit of " 
+ this.maxCellSize
+            + " bytes in region " + this;
+          if (LOG.isDebugEnabled()) {
+            LOG.debug(msg);
+          }
+          throw new DoNotRetryIOException(msg);
         }

Review comment:
       I will add debug msg.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org