bsglz commented on a change in pull request #1737:
URL: https://github.com/apache/hbase/pull/1737#discussion_r428412426
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -2444,8 +2451,16 @@ public FlushResultImpl flushcache(boolean
forceFlushAllStores, boolean writeFlus
}
try {
- Collection<HStore> specificStoresToFlush =
+ Collection<HStore> specificStoresToFlush = null;
+ if (!forceFlushAllStores && families != null) {
+ specificStoresToFlush = stores.entrySet().stream()
+ .filter(e -> families.contains(Bytes.toString(e.getKey())))
Review comment:
> So why we choose String instead of byte[] here?
1、The family name stored as private byte[] in ImmutableByteArray, if use
byte[], it need twice convertion.
2、We use the method of contains to filter them later, use string seems
esaliy to do.
Correct me if i have some mistake.
> If we want to use contains then we better use a Set instead of a List?
Yeah, you are right, wil fix.
Thanks a lot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
