[ 
https://issues.apache.org/jira/browse/HBASE-5848?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13261093#comment-13261093
 ] 

Lars Hofhansl commented on HBASE-5848:
--------------------------------------

The problem is that HBaseTestUtil.KEYS is used to two different things in the 
Tests: in HBaseAdmin.createTable* and in 
HBaseTestUtility.createMultiRegionsInMeta.
Ideally createMultiRegionsInMeta would be similar to HMaster.getHRegionInfos, 
but it is not. At this point it is too risky to change createMultiRegionsInMeta 
and createMultiRegions, so we should have to versions of HBaseTestUtil.KEYS - 
one that has the EMPTY_ROW for the test methods, and one that doesn't for the 
call to HMaster.createTable.

                
> Create table with EMPTY_START_ROW passed as splitKey causes the HMaster to 
> abort
> --------------------------------------------------------------------------------
>
>                 Key: HBASE-5848
>                 URL: https://issues.apache.org/jira/browse/HBASE-5848
>             Project: HBase
>          Issue Type: Bug
>          Components: client
>            Reporter: Lars Hofhansl
>            Assignee: ramkrishna.s.vasudevan
>            Priority: Minor
>             Fix For: 0.94.0, 0.96.0
>
>         Attachments: 5848-addendum-v2.txt, 5848-addendum-v3.txt, 
> 5848-addendum-v4.txt, HBASE-5848.patch, HBASE-5848.patch, 
> HBASE-5848_0.94.patch, HBASE-5848_addendum.patch
>
>
> A coworker of mine just had this scenario. It does not make sense the 
> EMPTY_START_ROW as splitKey (since the region with the empty start key is 
> implicit), but it should not cause the HMaster to abort.
> The abort happens because it tries to bulk assign the same region twice and 
> then runs into race conditions with ZK.
> The same would (presumably) happen when two identical split keys are passed, 
> but the client blocks that. The simplest solution here is to also block 
> passed null or EMPTY_START_ROW as split key by the client.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to