bharathv commented on a change in pull request #1775:
URL: https://github.com/apache/hbase/pull/1775#discussion_r430167887
##########
File path: hbase-examples/src/main/cpp/DemoClient.cpp
##########
@@ -79,15 +78,15 @@ main(int argc, char** argv)
return -1;
}
bool isFramed = false;
- boost::shared_ptr<TTransport> socket(new TSocket(argv[1],
boost::lexical_cast<int>(argv[2])));
- boost::shared_ptr<TTransport> transport;
+ std::shared_ptr<TTransport> socket(new TSocket(argv[1], std::stoi(argv[2])));
Review comment:
nit: switch to make_shared while you are here?
##########
File path: hbase-examples/src/main/cpp/DemoClient.cpp
##########
@@ -79,15 +78,15 @@ main(int argc, char** argv)
return -1;
}
bool isFramed = false;
- boost::shared_ptr<TTransport> socket(new TSocket(argv[1],
boost::lexical_cast<int>(argv[2])));
- boost::shared_ptr<TTransport> transport;
+ std::shared_ptr<TTransport> socket(std::make_shared<TSocket>(argv[1],
std::stoi(argv[2])));
Review comment:
I think you mean socket = make_shared<TSocket>.....
With your code, I think it calls into the move constructor..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
