VicoWu commented on a change in pull request #1764:
URL: https://github.com/apache/hbase/pull/1764#discussion_r431532580
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/SecureBulkLoadManager.java
##########
@@ -382,22 +382,27 @@ public String prepareBulkLoad(final byte[] family, final
String srcPath, boolean
throw new IOException("Path does not reference a file: " + p);
}
- // Check to see if the source and target filesystems are the same
- if (!FSUtils.isSameHdfs(conf, srcFs, fs)) {
- LOG.debug("Bulk-load file " + srcPath + " is on different filesystem
than " +
+ try {
Review comment:
From the code , we could find that if exception is thrown correctly
instead of swallowed, the retry attempts number could be controlled by
`hbase.client.retries.number` and `hbase.bulkload.retries.retryOnIOException`
instead of falling into a retry disaster and user cannot do anything because
the retry attempts number are controlled by number of regions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
