infraio commented on a change in pull request #1789:
URL: https://github.com/apache/hbase/pull/1789#discussion_r431571750
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/rsgroup/RSGroupBasedLoadBalancer.java
##########
@@ -77,6 +81,23 @@
private volatile RSGroupInfoManager rsGroupInfoManager;
private LoadBalancer internalBalancer;
+ /** Define the config key of if fallback group is enabled */
+ public static final String FALLBACK_GROUP_ENABLED_KEY =
"hbase.rsgroup.fallback.groups.enable";
+ public static final boolean FALLBACK_GROUP_ENABLED_DEFAULT = false;
+
+ /** Define the config key of fallback groups */
+ public static final String FALLBACK_GROUPS_KEY =
"hbase.rsgroup.fallback.groups";
+ public static final String FALLBACK_GROUPS_DEFAULT =
RSGroupInfo.DEFAULT_GROUP;
+
+ /** Define the config key of interval to correct fallback regions */
+ static final String FALLBACK_CORRECT_INTERVAL_KEY =
"hbase.rsgroup.fallback.correct.interval";
+ static final int FALLBACK_CORRECT_INTERVAL_DEFAULT = 10 * 60 * 1000; // 10min
+
+ private boolean fallbackEnabled;
+ private List<String> fallbackGroups;
+ @VisibleForTesting
+ FallbackCorrector fallbackCorrector;
Review comment:
Do we need this chore? This should be work of RSGroupBalancer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
