huaxiangsun commented on a change in pull request #1786: URL: https://github.com/apache/hbase/pull/1786#discussion_r431580567
########## File path: hbase-server/src/main/java/org/apache/hadoop/hbase/master/normalizer/SplitPlanFirstComparator.java ########## @@ -0,0 +1,40 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.hadoop.hbase.master.normalizer; + +import java.util.Comparator; + +/** + * Comparator class that gives higher priority to {@link SplitNormalizationPlan}. + */ +class SplitPlanFirstComparator implements Comparator<NormalizationPlan> { Review comment: The PlanComparator compares plans based on if it is a split or merge. It puts all split plan at the head of the list and merge plans put to the end of the list. Based on the addToList order, split plans are already added first, followed by merge plans, so my understanding is that this sort does nothing. plans.sort(planComparator); We can get rid of this comparator totally and simplify the code. Something missing in my understanding? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
