anoopsjohn commented on a change in pull request #1803:
URL: https://github.com/apache/hbase/pull/1803#discussion_r432638555
##########
File path:
hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HStore.java
##########
@@ -276,7 +276,8 @@ protected HStore(final HRegion region, final
ColumnFamilyDescriptor family,
// used by ScanQueryMatcher
long timeToPurgeDeletes =
Math.max(conf.getLong("hbase.hstore.time.to.purge.deletes", 0), 0);
- LOG.trace("Time to purge deletes set to {}ms in store {}",
timeToPurgeDeletes, this);
+ LOG.trace("Time to purge deletes set to {}ms in store {} in region {}",
timeToPurgeDeletes,
Review comment:
In all the places we have this pattern "in store {} in region {}"
Better we can change toString(). Include region and store name there. Then
in every log we can just refer to 'this'
<Region Name>:<Store Name> some format like this for toString?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
